[FFmpeg-devel] [PATCH] web: Copy FFmpeg Logo by Makefile instead of cronjob

[Thilo Borgmann]

Am 07.04.12 01:36, schrieb Michael Niedermayer:
> On Fri, Apr 06, 2012 at 11:53:16PM +0200, Thilo Borgmann wrote:
>> Am 06.04.12 17:43, schrieb Michael Niedermayer:
>>>> +LOGO_FILES := $(wildcard src/logik/$(DATE).*)
>>>
>>> what will happen if theres a
>>> src/logik/0605.`rm -rf .`$(SHELL rm -rf .)
>>> ?
>>
>> for `` files should be no target present (which I could also test...)
>> for $(shell...) things is that I don't think they get expanded any time after
>> being assigned.
>> I'm not familiar with usual hacks but I doubt someone who can write such a file
>> is not able to manually rm -rf anything in there already.
> 
> well, you can add files with a git account, you cant directly do a
> rm -rf with a git account
> and git definitly allows you to put funny chars in the names.
> 
> 
>> Does not matter anyway, we can change that line to something like:
>>
>> LOGO_FILES := $(wildcard src/logik/$(DATE).png src/logik/$(DATE).hover)
>>
>> According to the targets. Save enough?
> 
> looks ok to me but iam no makefile security expert ...
> 
> 
>>
>>
>>>>  src/logik/$(DATE)-standard:
>>>>  	cmp htdocs/FFmpeg_standard.png htdocs/ffmpeg-logo.png || \
>>>>  	cp htdocs/FFmpeg_standard.png htdocs/ffmpeg-logo.png
>>>> +	echo "FFmpeg" > src/template_head2_hovertext
>>>
>>> files in /src should not be written to, its a nightmare to maintain
>>> and in this case will not even work as the git hook will break on the
>>> next checkout
>>
>> Hm this is less easy to solve... What exactly does that git hook do?
> 
> it updates the checkout :)
> and if theres a changed file in there it will fail. (your patch
> contained the file too...)

Oh of course. Well it is a file because a new clone or a push at a day without
any $(DATE)* file should use the previously defined text. A new clone will fail
if there is no file already in the repo. Then I think...


>> Maybe it's sufficient and more suitable then to have an intermediate directory
>> for dynamically generated parts of the website?
> 
> cant the hover text be changed by CSS and the whole CSS file be changed
> like the logo ?

... it's unavoidable to have such a directory which contains files not under
version control. AFAIK CSS cannot handle the job - it can change color, size,
style and things but not influence a hovertext. One has to choose between
javascript or plain html for that.

-Thilo