[FFmpeg-devel] [PATCH] web: Copy FFmpeg Logo by Makefile instead of cronjob

[Thilo Borgmann]

Am 06.04.12 17:43, schrieb Michael Niedermayer:
>> +LOGO_FILES := $(wildcard src/logik/$(DATE).*)
> 
> what will happen if theres a
> src/logik/0605.`rm -rf .`$(SHELL rm -rf .)
> ?

for `` files should be no target present (which I could also test...)
for $(shell...) things is that I don't think they get expanded any time after
being assigned.
I'm not familiar with usual hacks but I doubt someone who can write such a file
is not able to manually rm -rf anything in there already.
Does not matter anyway, we can change that line to something like:

LOGO_FILES := $(wildcard src/logik/$(DATE).png src/logik/$(DATE).hover)

According to the targets. Save enough?


>>  src/logik/$(DATE)-standard:
>>  	cmp htdocs/FFmpeg_standard.png htdocs/ffmpeg-logo.png || \
>>  	cp htdocs/FFmpeg_standard.png htdocs/ffmpeg-logo.png
>> +	echo "FFmpeg" > src/template_head2_hovertext
> 
> files in /src should not be written to, its a nightmare to maintain
> and in this case will not even work as the git hook will break on the
> next checkout

Hm this is less easy to solve... What exactly does that git hook do?
Maybe it's sufficient and more suitable then to have an intermediate directory
for dynamically generated parts of the website?

-Thilo