[FFmpeg-devel] [PATCH 5/7] Check for out of bound reads in the flic decoder.

[Michael Niedermayer]

On Tue, Sep 27, 2011 at 11:43:55PM +0200, fenrir at elivagar.org wrote:
> From: Laurent Aimar <fenrir at videolan.org>


[...]
> @@ -218,6 +222,9 @@ static int flic_decode_frame_8BPP(AVCodecContext *avctx,
>                  if (color_changes == 0)
>                      color_changes = 256;
>  
> +                if (stream_ptr + color_changes * 3 > stream_ptr_after_chunk)
> +                    break;
> +

the addition as well as others can overflow, not really a big issue,
as its near impossible to happen in practice so this could probably
be applied as is if you prefer

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110928/a0388f16/attachment.asc>