[FFmpeg-devel] [PATCH] DVBSUBTILES, fixes to decoding/encoding and a new way of burning the subtitles onto the screen

[Michael Niedermayer]

On Sun, Sep 25, 2011 at 12:18:20AM +0200, Clément Bœsch wrote:
> From: joolzg <joolzg at btinternet.com>
> 
> ---
> Here is the second patch from Julian Gardner.
> 
> I did my best to remove the unrelated changes, fix the style and various other
> things, but it's still far from perfect. Some real reviews are needed.

Before i can review this, i first need an explanation of what these
changes are supposed to do.
like:
The changes in file1 are needed to fix X implement Y and you can test
this with file Z command line C
... file2 ...
...

A properly split patchset would be better than such list of course


[...]
> @@ -162,6 +162,21 @@ static uint8_t *audio_out;
>  static unsigned int allocated_audio_out_size, allocated_audio_buf_size;
>  
>  static short *samples;
> +
> +static AVBitStreamFilterContext *video_bitstream_filters;
> +static AVBitStreamFilterContext *audio_bitstream_filters;
> +static AVBitStreamFilterContext *subtitle_bitstream_filters;

unused


[...]
> @@ -1024,17 +1069,22 @@ static void dvbsub_parse_region_segment(AVCodecContext *avctx,
>          region = av_mallocz(sizeof(DVBSubRegion));
>  
>          region->id = region_id;
> +        region->version = -1;
>  
>          region->next = ctx->region_list;
>          ctx->region_list = region;
>      }
>  
> +    version = ((*buf)>>4) & 15;
>      fill = ((*buf++) >> 3) & 1;
> +    buf_size--;
>  
>      region->width = AV_RB16(buf);
>      buf += 2;
> +    buf_size -= 2;
>      region->height = AV_RB16(buf);
>      buf += 2;
> +    buf_size -= 2;

using buf_end is simpler and more robust than updating buf_size
synchronly with every buf update. buf_end is already there so this
seems unneeded


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Incandescent light bulbs waste a lot of energy as heat so the EU forbids them.
Their replacement, compact fluorescent lamps, much more expensive, dont fit in
many old lamps, flicker, contain toxic mercury, produce a fraction of the light
that is claimed and in a unnatural spectrum rendering colors different than
in natural light. Ah and we now need to turn the heaters up more in winter to
compensate the lower wasted heat. Who wins? Not the environment, thats for sure
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110927/795a97a9/attachment.asc>