[FFmpeg-devel] [PATCH] lavfi: rename avfilter_all_* function names to avfilter_make_all_*

Michael Niedermayer michaelni at gmx.at
Tue Sep 13 20:52:42 CEST 2011


On Tue, Sep 13, 2011 at 08:05:12PM +0200, Stefano Sabatini wrote:
> Function names should tell what the function does rather than what the
> function returns. This also avoids possible conflicts (e.g. between a
> function and a public list of all supported formats), and clarifies
> the code a bit.
> 
> Breaks audio API/ABI, add a backward compatibility layer for video API/ABI.
> ---
>  libavfilter/af_aformat.c   |    6 +++---
>  libavfilter/af_aresample.c |    4 ++--
>  libavfilter/avfilter.h     |   19 +++++++++++++++----
>  libavfilter/defaults.c     |    8 ++++----
>  libavfilter/formats.c      |   13 ++++++++++---
>  5 files changed, 34 insertions(+), 16 deletions(-)

LGTM

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110913/ab9b5e54/attachment.asc>


More information about the ffmpeg-devel mailing list