[FFmpeg-devel] [PATCH 3/3] lavfi: fix doxygen doc for AVFilterLink.time_base

[Michael Niedermayer]

On Sun, Sep 11, 2011 at 01:47:29PM +0200, Stefano Sabatini wrote:
> On date Tuesday 2011-08-09 16:04:59 +0200, Michael Niedermayer encoded:
> > On Mon, Aug 08, 2011 at 11:59:48AM +0200, Stefano Sabatini wrote:
> > > On date Saturday 2011-08-06 20:26:01 +0200, Michael Niedermayer encoded:
> > > > On Sat, Aug 06, 2011 at 01:29:18PM +0200, Stefano Sabatini wrote:
> > > [...]
> > > > > What about removing sample_rate from link, and use time_base instead:
> > > > >    if (audio)
> > > > >        time_base = (AVRational) { 1, sample_rate };
> > > > > ?
> > > > 
> > > > what would you do when the input to the filter chain uses a timebase
> > > > that has units that arent representable in the sample rate ?
> > > 
> > > So are you suggesting to drop sample_rate and use time_base instead?
> > > What else? Please be more explicit.
> > 
> > i would suggest that time_base be used, yes
> 
> Check patch.
> -- 
> FFmpeg = Freak Funny Muttering Ponderous Evangelical Governor

>  af_aresample.c  |   17 +++++++++--------
>  asrc_abuffer.c  |   10 +++++-----
>  asrc_anullsrc.c |    2 +-
>  avfilter.c      |   13 +++++++------
>  avfilter.h      |    2 +-
>  src_movie.c     |    3 +--
>  6 files changed, 24 insertions(+), 23 deletions(-)
> 51bec87be84802e5f9b4d23c1462e6e2c637ee0f  0007-lavfi-drop-AVFilterLink.sample_rate-at-the-next-majo.patch
> From f628e4a4a6f55412117779e9e7f1680b4eec49e4 Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> Date: Thu, 18 Aug 2011 22:53:58 +0200
> Subject: [PATCH] lavfi: drop AVFilterLink.sample_rate at the next major bump
> 
> Use time_base instead for storing such information.
> 
> This allows duplication of information, and simplify PTS handling for
> the unified API, as time_base can be used for computing both audio and
> video buffers timestamps.

iam ok with this, just one note to make sure we dont by mistake run in
an issue with it

mpeg-ps has a timebase of 90khz and samplerates of 44.1,48,22.05, ...
that means if we want to preserve this through the filter chains
(and i dont know if we want or dont want...)
then we need both timebase & sample_rate
otoh i dont mind at all to drop that extra complexity and use a
timebase equal to the samplerate

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110912/e398fb70/attachment.asc>