[FFmpeg-devel] [PATCH] flvdec: Remove AVFMTCTX_NOHEADER when there is only 1 stream

[Asad Mehmood]

On 7 September 2011 12:08, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Wed, Sep 07, 2011 at 11:07:56AM +0100, Asad Mehmood wrote:
> this seems missing a check that there is actually one stream and not
> 0

The code should only be called when there is 1 stream ...
If the flags claim there to be 0 streams flvdec will assume there to
be 2 streams
and acodec and vcodec will not be null.

>if (!flags) {
>    flags = FLV_HEADER_FLAG_HASVIDEO | FLV_HEADER_FLAG_HASAUDIO;

AVFMTCTX_NOHEADER is only set when the flags claim 1 stream ... to
find "ghost" streams
If the metadata also claims there to be 1 stream. I believe
find_stream_info should not be
searching for such streams.

:)