[FFmpeg-devel] [PATCH] gxf: add timecode information to metadata

[Reimar Döffinger]

On Mon, Oct 31, 2011 at 08:37:34PM +0100, Reimar Döffinger wrote:
> On Mon, Oct 31, 2011 at 08:04:05PM +0100, Matthieu Bouron wrote:
> > Patch updated,
> > Does it look good to you ?
> 
> Almost.
> I mean putting the full 64 bit TRACK_AUX into the gxf_stream_info
> and then checking the track type and adding metadata after coming
> back from the tag parsing function (ok, whether the full 64 bit
> or just the time code does not really matter, just seems nicer going
> with the full 64 bit).
> I.e. the tag parsing function really should only parse the tags
> into the gxf_stream_info, processing them should be in the function
> one level up.

Also note that by merging the new tlen and tag checks into a single
if you can avoid duplicating the skip case.
I can make these changes myself if you get tired of those nits,
though I don't have any sample to test it on, so it seems easier
to leave it to you.