[FFmpeg-devel] [PATCH] gxf: add timecode information to metadata

[Matthieu Bouron]

Patch updated.
Current code assumes UMF Material description to be present, and reads
its first byte to determine sample rate. Timecode at mark in|out are
part of this table, so it shouldn't be a problem to test if len >=
0x51.

2011/10/28 Reimar Döffinger <Reimar.Doeffinger at gmx.de>:
> Don't have time to fully review, but:
>
> On Thu, Oct 27, 2011 at 10:04:37PM +0200, Matthieu Bouron wrote:
>> @@ -341,8 +388,10 @@ static int gxf_header(AVFormatContext *s, AVFormatParameters *ap) {
>>          if (len >= 0x39) {
> [...]
>> +            len -= 0x51;
>
> These do not go together.
> I do not know if the UMF packet is actually required to be that large,
> but even if it is I'm not sure I like the idea of requiring that,
> considering how broken a lot of (if not most) files are.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-gxf-add-timecode-information-to-metadata.patch
Type: application/octet-stream
Size: 5598 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111028/8899de1f/attachment.obj>