[FFmpeg-devel] [PATCH] ffprobe: print non-time values like integer if they have no decimal part

[Michael Niedermayer]

On Mon, Oct 24, 2011 at 02:40:02AM +0200, Stefano Sabatini wrote:
> Prettify, simplify parsing for integer values.
> ---
>  ffprobe.c |   16 ++++++++++++----
>  1 files changed, 12 insertions(+), 4 deletions(-)
> 
> diff --git a/ffprobe.c b/ffprobe.c
> index 5913d60..c21c57c 100644
> --- a/ffprobe.c
> +++ b/ffprobe.c
> @@ -90,11 +90,19 @@ static char *value_string(char *buf, int buf_size, double val, const char *unit)
>              prefix_string = decimal_unit_prefixes[index];
>          }
>  
> -        snprintf(buf, buf_size, "%.3f%s%s%s", val, prefix_string || show_value_unit ? " " : "",
> -                 prefix_string, show_value_unit ? unit : "");
> +        if (val != (int)val)

i think this can crash with nan/inf


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

DNS cache poisoning attacks, popular search engine, Google internet authority
dont be evil, please
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111024/6c17c61a/attachment.asc>