[FFmpeg-devel] [PATCH] Make AVCodecTag non-opaque.

Michael Niedermayer michaelni at gmx.at
Sat Oct 22 18:15:06 CEST 2011


On Sat, Oct 22, 2011 at 05:18:56PM +0200, Reimar Döffinger wrote:
> On Sat, Oct 22, 2011 at 05:12:04PM +0200, Michael Niedermayer wrote:
> > On Sat, Oct 22, 2011 at 01:03:53PM +0200, Reimar Döffinger wrote:
> > > This may make keeping ABI-compatibility harder, but without it
> > > av_codec_get_id and av_codec_get_tag cannot be reused by
> > > applications for their own purposes.
> > 
> > We could add public functions and structures for searching
> > through int[2] lists if such do not exists yet. This could even be
> > made more generically to int[n] lists and a single function.
> 
> int[2] is not between enum CodecID and uint32_t, that means
> casting hacks for that use case.

so what do you suggest ?
applying your patch to ffmpeg risks breaking compatibility with libav.
and this seems unreasonable for saving 10 lines of code in mplayer

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111022/39e27734/attachment.asc>


More information about the ffmpeg-devel mailing list