[FFmpeg-devel] [PATCH] presets: remove redundant libx264 preset files

[Lou Logan]

On Fri, 21 Oct 2011 23:29:13 +0200, Michael Niedermayer wrote:

> On Fri, Oct 21, 2011 at 01:21:24PM -0800, Lou Logan wrote:
> >  libx264-baseline.ffpreset            |    1 -
> >  libx264-fast.ffpreset                |    1 -
> >  libx264-fast_firstpass.ffpreset      |    2 --
> >  libx264-faster.ffpreset              |    1 -
> >  libx264-faster_firstpass.ffpreset    |    2 --
> >  libx264-lossless_fast.ffpreset       |    2 --
> >  libx264-lossless_max.ffpreset        |    2 --
> >  libx264-lossless_medium.ffpreset     |    2 --
> >  libx264-lossless_slow.ffpreset       |    2 --
> >  libx264-lossless_slower.ffpreset     |    2 --
> >  libx264-lossless_ultrafast.ffpreset  |    2 --
> >  libx264-main.ffpreset                |    1 -
> >  libx264-medium.ffpreset              |    1 -
> >  libx264-medium_firstpass.ffpreset    |    2 --
> >  libx264-placebo.ffpreset             |    1 -
> >  libx264-placebo_firstpass.ffpreset   |    2 --
> >  libx264-slow.ffpreset                |    1 -
> >  libx264-slow_firstpass.ffpreset      |    2 --
> >  libx264-slower.ffpreset              |    1 -
> >  libx264-slower_firstpass.ffpreset    |    2 --
> >  libx264-superfast.ffpreset           |    1 -
> >  libx264-superfast_firstpass.ffpreset |    2 --
> >  libx264-ultrafast.ffpreset           |    1 -
> >  libx264-ultrafast_firstpass.ffpreset |    2 --
> >  libx264-veryfast.ffpreset            |    1 -
> >  libx264-veryfast_firstpass.ffpreset  |    2 --
> >  libx264-veryslow.ffpreset            |    1 -
> >  libx264-veryslow_firstpass.ffpreset  |    2 --
> >  28 files changed, 44 deletions(-)
> > 1843b15db5fb2ccb87cc2befcb5aa92c942e0ac2
> > 0001-Remove-redundant-libx264-preset-files.patch From
> > 1bca9c3a3c42db02782e716cafc84a2d87d40322 Mon Sep 17 00:00:00 2001
> > From: Lou Logan <lou at lrcd.com> Date: Fri, 21 Oct 2011 13:08:33 -0800
> > Subject: [PATCH] Remove redundant libx264 preset files
> > 
> > These are available via -preset or -vprofile and the addition of
> > -qp 0 or -crf 0 if lossless is desired.
> 
> ill wait until tomorrow and if noone stated that he would miss these
> by then, then ill apply

We already deleted these, but libav did not: 14360e07, a96b171,
f234cd0. They were re-introduced by a recent merge from libav and
reverting it might make more sense than this patch, but I don't know
what is preferable. I should have mentioned that.

I do not believe there is a reason to have both the text file presets
and the ability to access them directly with -preset/-vprofile. Seems
redundant and confusing for users.

> also the documentation should be updated so users know what to use
> instead of these

You already did document the lossless presets with eb11cca and the
change from file based presets was mentioned on the web site May 3,
2011, but yes, more documentation is good.