[FFmpeg-devel] GOP_START_CODE definition conflict

[C Chatterjee]

Found an issue with MPEG1/2 and MPEG4 definitions.

In particular we have:

libavcodec\mpegvideo.h(75):#define GOP_START_CODE          0x000001b8
which is the MPEG1/2 definition of GOP Start code.
These are redefined in:
libavformat\mpegvideodec.c(27):#define GOP_START_CODE          0x000001b8
why?
#define SEQ_START_CODE          0x000001b3
#define GOP_START_CODE          0x000001b8
#define PICTURE_START_CODE      0x00000100
#define SLICE_START_CODE        0x00000101


Also we have:
libavcodec\mpeg4video.h(58):#define GOP_STARTCODE        0x1B3
which is the MPEG4 definition.

Although the subtle _ difference exits, it will be easier to name the latter say GVOP_START_CODE ie Group of VOP startcode.
Also we should take out the redefinition in libavformat\mpegvideodec.c.

Chanchal Chatterjee