[FFmpeg-devel] Simplify use of audio_resample

[Michael Niedermayer]

On Tue, Oct 18, 2011 at 10:17:57AM +0200, Clément Bœsch wrote:
> Hi,
> 
> I'm not sure to understand the motive of having some audio_resample heuristics
> in transcode_init() and more in do_audio_out() (with some duplicates); if there
> is no particular reason for this, the first patch is meant to regroup the
> audio_resample R/W into do_audio_out() only.
> 
> Then the flag is just removed from OutputStream in the second patch since it
> does not seem needed anymore.
> 
> I guess more simplifications could be done, but before I eventually try that I'd
> like to know if I'm not missing any particular special cases since that part of
> the code isn't quite obvious.
> 
> fate seems ok, but I'm not sure there are some tests for this.

please test with some file that changes its audio parameters mid stream
it should work to just concatenate 2 mp3 or mpeg-ps with diffenrent
parameters
also please test -async != 0
if all that works the patches should be ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111018/1c2329e2/attachment.asc>