[FFmpeg-devel] [PATCH 1/2] ffplay: avoid window resize crash on osx with libsdl 1.2.14

[Michael Niedermayer]

On Wed, Oct 12, 2011 at 09:53:05PM +0000, Carl Eugen Hoyos wrote:
> Jean First <jeanfirst <at> gmail.com> writes:
> 
> > +++ b/ffplay.c
> > @@ -947,13 +947,7 @@ static int video_open(VideoState *is){
> >      if(screen && is->width == screen->w && screen->w == w
> >         && is->height== screen->h && screen->h == h)
> >          return 0;
> > -
> > -#ifndef __APPLE__
> >      screen = SDL_SetVideoMode(w, h, 0, flags);
> > -#else
> > -    /* setting bits_per_pixel = 0 or 32 causes blank video on OS X */
> > -    screen = SDL_SetVideoMode(w, h, 24, flags);
> > -#endif
> 
> This patch causes a double-free on exit in SDL_FreeYUVOverlay() for me on PPC
> oSX 10.5, but since it fixes wrong colours in many samples, I am all for it.

The double free should be reported to the SDL developers. Either we are
doing something wrong or theres a bug in SDL.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111013/a6f0e9ee/attachment.asc>