[FFmpeg-devel] Would like to contribute changes to 0.6.3 version

[Levin Igor]

On Wednesday, 12 October 2011 at 11:51, Dominik 'Rathann' Mierzejewski wrote:
> On Wednesday, 12 October 2011 at 02:46, Michael Niedermayer wrote:
> > On Tue, Oct 11, 2011 at 10:36:49PM +0200, Levin Igor wrote:
> > >
> > >                 Hi.
> > > I'm a software engineer in a company and I recently used FFMPEG version
> > > 0.6.1 to read and write from .mov and .3gp format containers in my project.

> Great! However, please keep in mind that 0.6.x is ancient and no longer
> maintained.

> > > I've made a few relatively minor changes to the base FFMPEG code,
> > > mostly to store additional metadata with H264 stream (like maximum NALU
> > > size, for example). This changed code worked well for me and was tested.
> > > I'd like now to contribute my changes back to the community. What is the
> > > recommended way of doing this ?
> >
> > Simply send clean patches generated with git format-patch or equivalnet
> > to ffmpeg-devel.
> > Make sure each patch does not contain unrelated changes

> Additionally, please remake the patches against current git master,
> as 0.6.x is too old.

> Regards,
> Dominik

 I've remade changes against 0.6.3, which I saw is a current master of a 0.6 branch. Attached are the outputs of 'diff' for the changed files.
Modification history comments are embedded within the files and are subsequently part of the diff.

Brief description of changes:
1. Files libacodec/h264.c and libavcodec/h264.h - added an externally accessible function to update image size and PAR from SPS without decoding the stream.
2. File libavformat/isom.h - allow reading "udta" box on a stream level, to access SDP information.
3. File libavformat/mov.c - support for parsing "udta" box on a stream level, reading stored "max NALU size" and "max bitrate" for the stream.
4. File libavformat/movenc.c:
        a) allow storing AMR mode 15 (silent) frame
        b) support for storing "max NALU size", "max bitrate".

 For Your consideration, and thanks in advance for Your time.
        Igor.

“This e-mail message may contain confidential, commercial or privileged information that constitutes proprietary information of Comverse Technology or its subsidiaries. If you are not the intended recipient of this message, you are hereby notified that any review, use or distribution of this information is absolutely prohibited and we request that you delete all copies and contact us by e-mailing to: security at comverse.com. Thank You.”
-------------- next part --------------
A non-text attachment was scrubbed...
Name: movenc.c.diff
Type: application/octet-stream
Size: 9513 bytes
Desc: movenc.c.diff
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111012/6579403c/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: h264.c.diff
Type: application/octet-stream
Size: 3312 bytes
Desc: h264.c.diff
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111012/6579403c/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: h264.h.diff
Type: application/octet-stream
Size: 1486 bytes
Desc: h264.h.diff
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111012/6579403c/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: isom.h.diff
Type: application/octet-stream
Size: 1012 bytes
Desc: isom.h.diff
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111012/6579403c/attachment-0003.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mov.c.diff
Type: application/octet-stream
Size: 9187 bytes
Desc: mov.c.diff
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111012/6579403c/attachment-0004.obj>