[FFmpeg-devel] [PATCH] libmodplug: add bintext video stream capability.

[Michael Niedermayer]

On Sun, Oct 09, 2011 at 05:32:53PM +0200, Clément Bœsch wrote:
> On Sun, Oct 09, 2011 at 03:25:39PM +0200, Reimar Döffinger wrote:
> > On Sun, Oct 09, 2011 at 03:05:31PM +0200, Clément Bœsch wrote:
> > > ---
> > >  libavformat/libmodplug.c |  165 +++++++++++++++++++++++++++++++++++++++++++++-
> > >  1 files changed, 162 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/libavformat/libmodplug.c b/libavformat/libmodplug.c
> > > index edae4b3..00cd12e 100644
> > > --- a/libavformat/libmodplug.c
> > > +++ b/libavformat/libmodplug.c
> > > @@ -27,6 +27,10 @@
> > >  #include "libavutil/opt.h"
> > >  #include "avformat.h"
> > >  
> > > +#if CONFIG_BINTEXT_DECODER
> > > +#include "libavutil/eval.h"
> > > +#endif
> > 
> > There is no reason at all to have the include under this #if.
> > Generally I don't see why you need to check CONFIG_BINTEXT_DECODER,
> > I don't see any of the code depending on it.
> > Yes, you will need to it actually display it, but e.g. transcoding
> > with FFmpeg should not have any need at all for the decoder, only
> > when you play the file then you'd need it.
> 
> OK, I see, new patch attached.

applied

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111010/0a0b1d10/attachment.asc>