[FFmpeg-devel] [PATCH] Add libmodplug support.

[Laurent Aimar]

On Wed, Oct 05, 2011 at 09:47:38PM +0200, Clément Bœsch wrote:
> On Wed, Oct 05, 2011 at 07:13:18PM +0200, Reimar Döffinger wrote:
> [...]
> > Also, any chance of getting a probe function?
> 
> Oh and forgot to reply to that…
> 
> Actually, the API isn't really handy to use. I'd say probing a N bytes
> buffer, sending it to ModPlug_Load() and check if it returns something not
> NULL might work. But I don't know if libmodplug actually has a default
> format fallback (just like heuristics which tend to detect /dev/random as
> MP3), or if a integrity check might lead to a failure (since the buffer is
> incomplete), etc. So I believe extensions are fine ATM.
> 
> Another solution would be to manually check for a list of potential
> headers, but I don't think it belongs to that module code.
 We have that in the VLC demuxer code as:
 - extension are quite unreliable.
 - ModPlug_Load() will happily open a lot of files that it should refuse.

-- 
fenrir