[FFmpeg-devel] [PATCH] ffprobe: add compact and compactnk writers
Stefano Sabatini
stefasab at gmail.com
Sun Oct 2 12:57:21 CEST 2011
On date Wednesday 2011-09-28 01:19:06 +0200, Alexander Strasser encoded:
> Hi
>
> Stefano Sabatini wrote:
> > On date Sunday 2011-09-25 16:26:55 +0200, Alexander Strasser encoded:
> > > Stefano Sabatini wrote:
> [...]
> > > > I added escaping (which may be used e.g. for CSV output), and change
> > >
> > > I think for CSV output it would be better to adhere to RFC 4180.
> > > Probably with the exception of "Each line should contain the same
> > > number of fields throughout the file.", but that is "should" anyway.
> >
> > MS-escaping (as described in RFC4180) is mal-designed and thus I'm not
> > eager to make of this the default escaping algo, I suppose the best
> > option is to make the escaping algorithm configurable, which requires
> > some major redesign.
>
> If it should be default or not I cannot judge, but it would make sense
> because it is what people usually expect when talking about CSV (if that
> can at all be said about such a adhoc/no-real-spec file format).
>
> But as you say, being able to choose the escaping algo would probably
> be nice to have.
>
> > I prefer to do this *after* committing this patch though.
>
> Of course; this comment was not meant to apply to this commit.
>
> The other comment about escaping key values was though.
key values are always identifier strings, so they don't need escaping,
we can add escaping (which requires only a few lines change) if we
break that rule.
RFC4180 quoting is not yet supported, I prefer to add it later as a
following patch, feel free to send a patch for that if I won't.
New patch depends on the other ones just sent.
--
FFmpeg = Foolish and Fierce Merciless Portable Enhancing Guru
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-ffprobe-add-compact-writer.patch
Type: text/x-diff
Size: 5722 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111002/55d4506b/attachment.bin>
More information about the ffmpeg-devel
mailing list