[FFmpeg-devel] ffplay: fix order of operations for sdl audio open

Marton Balint cus at passwd.hu
Sat Oct 1 21:41:00 CEST 2011


Hi,

The patch in the subject (3715e675) seems broken in some ways:

  - The sample rate / channel count sanity check is not against the
    actually used sample rate / channel count.

  - Avctx->request_channels can affect the number of the channels,
    therefore downmixing of 5.1 audio to stereo (default for ffplay)
    currently does not work because of the patch.

Isn't the aac decoder should be fixed instead of ffplay to return the 
proper number of channels after calling avcodec_open2?

Regards,
   Marton


More information about the ffmpeg-devel mailing list