[FFmpeg-devel] [PATCH] J2K encoder: fix bpp and add support for 9, 10, and 16 bit YUV

[Michael Bradshaw]

On Tue, Nov 29, 2011 at 1:03 AM, Jean First <jeanfirst at gmail.com> wrote:

>       .long_name = NULL_IF_CONFIG_SMALL("OpenJPEG based JPEG 2000
>>> encoder"),
>>>
>>>>  } ;
>>>> --
>>>> 1.7.7
>>>>
>>>>
>>>>  by the way - there are some quite long lines that could be wraped.
>>>
>>>  I'll try and keep them shorter and possibly fix some of the currently
>> longer ones in a future patch.  Attached is a patch that fixes the two
>> issues discussed.
>>
>
> nice.
> And while at it will improve the readability alot if you f.ex align the
> AVCodec struct at the = signs and align the code at some other places where
> the code looks like a block.
>

Done.  I'll try and continue to improve the other long lines as time goes
on.


I think you get a lot of karma if writing it like this (or similar) - if
> you put PIX_FMT_RGB24 at the filrst place, it will
> be the first choice for AVFilter swscale autoinserting...
>
>
>    .pix_fmts = (const enum PixelFormat[]){ PIX_FMT_RGB24,     PIX_FMT_RGBA,
> PIX_FMT_GRAY8,
>                                            PIX_FMT_YUV420P,
> PIX_FMT_YUV422P,
>                                            PIX_FMT_YUV440P,
> PIX_FMT_YUV444P,
>                                            PIX_FMT_YUV420P9,
>  PIX_FMT_YUV422P9,  PIX_FMT_YUV444P9,
>                                            PIX_FMT_YUV420P10,
> PIX_FMT_YUV422P10, PIX_FMT_YUV444P10,
>                                            PIX_FMT_YUV420P16,
> PIX_FMT_YUV422P16, PIX_FMT_YUV444P16 },


Done as well.  Thanks for your input (and thanks to Carl Hoyos as well) on
this, as I didn't know the order of the pixel formats affected FFmpeg.

If someone with commit rights to FFmpeg would like to merge my repo, it's
ready.  If someone wants to review the changes more though, I've attached a
patch that contains all the changes made.
https://github.com/mjbshaw/FFmpeg-OpenJPEG-J2K-Encoder

Thanks,

Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-BPP-fix-YUVP9-10-16-support-make-RGB24-default.patch
Type: application/octet-stream
Size: 6985 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111130/9dfcda83/attachment.obj>