[FFmpeg-devel] [PATCH] Add coverage support.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Wed Nov 30 00:12:53 CET 2011


On Tue, Nov 29, 2011 at 02:48:40PM -0800, Mike Melanson wrote:
> > Adds --enable-coverage to configure and a "coverage-html" make target.
> The dependency stuff in the Makefile is a bit questionable, but the best
> I could think of so far.
> 
> Nice. This is a nitpick, but should there be a check if lcov is installed
> if this option is selected?

IMO no. Ideally we should probably check and error out if the compiler
does not support the -f flags, but it seems a bit like overkill (and
might happen indirectly anyway).
That is enough to generate coverage reports.
The Makefile part does require lcov, however that is completely
optional, other people might actually want to use other tools on the
coverage data, so I'm in favour of not requiring lcov.
I'd hope that anyone who cares about coverage data will be able to
figure out what it means when they get a message that lcov was not
found...


More information about the ffmpeg-devel mailing list