[FFmpeg-devel] [PATCH] libavfilter - avfilter_make_format_list skips sentinel -1

[Stefano Sabatini]

On date Wednesday 2011-11-23 00:15:39 +0100, Robert Nagy encoded:
> Sorry for improper handwritten patch.
> 
> Fixes a problem where 'avfilter_make_format_list' skips last element, thus
> does no end the format list with -1.
> 
> >libavfilter\formats.c
> >
> >AVFilterFormats *avfilter_make_format_list(const int *fmts)
> >{
> >    MAKE_FORMAT_LIST();
> >+    formats->formats[count] = -1;

formats->formats[count] should never be read.

Can you say why and in which conditions this is causing problems?

> >    while (count--)
> >        formats->formats[count] = fmts[count];
> >
> >    return formats;
> >}

(ah, and I don't care about the patch format, I'll just fix it before
committing).
-- 
FFmpeg = Faithful & Fast Murdering Practical Exuberant Ghost