[FFmpeg-devel] [PATCH] vf_mp: rewrite vf_mp filter warning message

[Stefano Sabatini]

On date Tuesday 2011-11-22 21:41:14 +0100, Clément Bœsch encoded:
> On Tue, Nov 22, 2011 at 06:55:42PM +0100, Michael Niedermayer wrote:
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > ---
> >  libavfilter/vf_mp.c |    5 ++---
> >  1 files changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/libavfilter/vf_mp.c b/libavfilter/vf_mp.c
> > index 6541f6d..9727f17 100644
> > --- a/libavfilter/vf_mp.c
> > +++ b/libavfilter/vf_mp.c
> > @@ -712,9 +712,8 @@ static av_cold int init(AVFilterContext *ctx, const char *args, void *opaque)
> >      int i;
> >  
> >      av_log(ctx, AV_LOG_WARNING,
> > -"This is a unholy filter, it will be purified by the ffmpeg exorcist team\n"
> > -"which will change its syntax from dark -vf mp to light -vf.\n"
> > -"Thou shalst not make spells or scripts that depend on it\n");
> > +"Using libmpcodecs filter, this filter may be removed once it has been ported\n"
> > +"to a native libavfilter.\n");
> >  
> >      m->avfctx= ctx;
> 
> Sounds better than the current warning :)
> 
> Ideally I'd mention MPlayer and the filter name, lets say: "'%s' is a
> wrapped MPlayer filter (libmpcodecs). This filter...". You wording sounds
> good to me anyway, but I'm not a native speaker.

I always enjoyed the magical lingo of the original warning, so I'll
probably miss it :-). Anyway if you prefer to change it I'm fine with
it, the suggestion from Clement looks good to me.
-- 
FFmpeg = Freak & Fantastic Mega Portentous Elected Gigant