[FFmpeg-devel] [PATCH] lavfi: reimplement MPlayer's af_pan filter for libavfilter.

[Nicolas George]

Le septidi 27 brumaire, an CCXX, Stefano Sabatini a écrit :
> At your discretion you may want to change authorship at this point,
> and mention Clement in the commit message.

I tweaked the commit message.

> Nit++++: (C) -> (c) for consistency

Done.

> this comment may be more explicit, or entirely removed

Done.

> please rename channel to something like channel_nb or add a
> comment (channel as is suggest a channel layout with a single channel)

channel_id, since it is called that elsewhere.

> I'd suggest nb_channels here, "number of named" is quite confusing,

nb_in_channels.

> maybe together with #define NAMED 1.

This seems overkill.

> Note: I wonder if we have a function which counts bits

av_get_channel_layout_nb_channels does it, in fact. But there are arithmetic
tricks that work well to speed up things, it may be a good addition.

> maybe add a comment about what degenerate means in this context

Done.

> Nit: printing some context information (e.g. gain value and indices i
> j) may be helpful here

Good remark, done.

> av_clipf?

I looked for it but did not find it at first, thanks. I also fixed the
interval, the limit was 128 and not 256 (although it would probably fit up
to 255, in fact).

New version incoming.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111117/3eef1e1a/attachment.asc>