[FFmpeg-devel] [PATCH 02/10] swr: rename AVAudioConvert to SwrAudioConvert.

[Michael Niedermayer]

On Wed, Nov 16, 2011 at 11:22:51PM +0100, Clément Bœsch wrote:
> On Wed, Nov 16, 2011 at 09:50:49PM +0100, Clément Bœsch wrote:
> > Use public libswresample struct prefix for consistency purpose. This
> > also avoid the confusion with the old audio convert code.
> > ---
> >  libswresample/audioconvert.c        |   18 +++++++++---------
> >  libswresample/audioconvert.h        |   16 ++++++++--------
> >  libswresample/swresample_internal.h |    6 +++---
> >  3 files changed, 20 insertions(+), 20 deletions(-)
> > 
> 
> After a discussion on IRC, it was clarified that everything not in
> swresample.h is *not* public. Also note that patch wasn't a proper
> export because AudioData wasn't exported (and needed in prototypes).
> 
> In consequence, a new patch is attached, and makes that part of the API
> explicitly private. The rest of the patch is locally rebased onto it.
> 
> [...]
> 
> -- 
> Clément B.

>  audioconvert.c        |   18 +++++++++---------
>  audioconvert.h        |   16 ++++++++--------
>  swresample.c          |   30 +++++++++++++++---------------
>  swresample_internal.h |    6 +++---
>  4 files changed, 35 insertions(+), 35 deletions(-)
> b153b0b70f2fcaa7e9925fadc0f845049528d3c3  0002-swr-make-audio-convert-code-explicitely-private.patch
> From 7a252d3288838c1c82eccc2adfc17f695669ed7a Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Cl=C3=A9ment=20B=C5=93sch?= <ubitux at gmail.com>
> Date: Wed, 16 Nov 2011 08:00:31 +0100
> Subject: [PATCH 02/10] swr: make audio convert code explicitely private.
> 
> Only what's declared in libswresample/swresample.h is public.

LGTM

]...[

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111116/a8a26ce6/attachment.asc>