[FFmpeg-devel] [PATCH 1/2] mpeg12: raise timecode string to codec context.

[Clément Bœsch]

On Wed, Nov 16, 2011 at 06:07:50PM +0100, Michael Niedermayer wrote:
> On Wed, Nov 16, 2011 at 05:52:33PM +0100, Clément Bœsch wrote:
> > From: Clément Bœsch <clement.boesch at smartjog.com>
> > 
> > ---
> >  doc/APIchanges       |    3 +++
> >  libavcodec/avcodec.h |    7 +++++++
> >  libavcodec/mpeg12.c  |   10 ++++++----
> >  libavcodec/version.h |    2 +-
> >  4 files changed, 17 insertions(+), 5 deletions(-)
> > 
> > diff --git a/doc/APIchanges b/doc/APIchanges
> > index 8a2a9de..cc72063 100644
> > --- a/doc/APIchanges
> > +++ b/doc/APIchanges
> > @@ -13,6 +13,9 @@ libavutil:   2011-04-18
> >  
> >  API changes, most recent first:
> >  
> > +2011-11-xx - xxxxxxx - lavc 53.35.0
> > +  Add timecode string (timecode_str) to AVCodecContext.
> > +
> >  2011-11-03 - 96949da - lavu 51.23.0
> >    Add av_strcasecmp() and av_strncasecmp() to avstring.h.
> >  
> > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> > index d62cbfb..88ebbad 100644
> > --- a/libavcodec/avcodec.h
> > +++ b/libavcodec/avcodec.h
> > @@ -2679,6 +2679,13 @@ typedef struct AVCodecContext {
> >       */
> >      int64_t timecode_frame_start;
> >  
> > +    /**
> > +     * Codec timecode string
> > +     * - encoding: unused
> > +     * - decoding: set by libavcodec
> > +     */
> > +    char timecode_str[16];
> > +
> >  #if FF_API_REQUEST_CHANNELS
> 
> adding it in the middle can cause ABI issues

Ah, I thought it was just for the first fields, my bad, I'll add the
entry at the end.

> also a note saying that it should only be accessed via av_opt*
> would avoid ABI issues if it moves
> char [16] might not work well with av_opt though
> 

Removing the [16] will likely make things slower (or a bit more
complicated for codecs to avoid the allocation). I'll try to do something
about that though.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111116/1049f627/attachment.asc>