[FFmpeg-devel] [PATCH 1/2] vble: move 2nd pass bitreading into vble_restore_plane() this improves data cache hits and speeds up grayscale only decoding

Michael Niedermayer michaelni at gmx.at
Mon Nov 14 19:10:29 CET 2011


On Mon, Nov 14, 2011 at 12:20:53PM -0500, Derek Buitenhuis wrote:
> On 14/11/2011 11:37 AM, Michael Niedermayer wrote:
> >Signed-off-by: Michael Niedermayer<michaelni at gmx.at>
> >---
> >  libavcodec/vble.c |   22 ++++++++++------------
> >  1 files changed, 10 insertions(+), 12 deletions(-)
> 
> Looks good. Just one nit, noted below.
> 
> >-static void vble_restore_plane(VBLEContext *ctx, int plane, int offset,
> >+static void vble_restore_plane(VBLEContext *ctx, GetBitContext *gb, int plane, int offset,
> >                                int width, int height)
> 
> Nit: I would like it if you could modify these to lines (and
> the line break) so that they file in 80 cols.

fixed & applied

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111114/7f8b99b8/attachment.asc>


More information about the ffmpeg-devel mailing list