[FFmpeg-devel] [PATCH 1/2] vble: move the sign calculation to vble_unpack()

[Michael Niedermayer]

On Mon, Nov 14, 2011 at 12:38:30AM -0500, Derek Buitenhuis wrote:
> On 13/11/2011 9:24 PM, Michael Niedermayer wrote:
> >Signed-off-by: Michael Niedermayer<michaelni at gmx.at>
> >---
> >  libavcodec/vble.c |    8 +++++---
> >  1 files changed, 5 insertions(+), 3 deletions(-)
> 
> Looks fine, but what exactly is the reason for this?
> 
> >+        if (ctx->val[i]){
> 
> Needs a space before the {.
> 
> >+            int v = (1<<  ctx->val[i]) + get_bits(gb, ctx->val[i]) - 1;
> 
> I'd personally prefer that the declarations all be at the beginning
> of the function.

it could lead to speed losses as the compiler has to proove the
variables dont need to be preserved outside
do you still want me to make this change ?

also ill post a better patchset soon that doesnt move the sign stuff
to vble_unpack()

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111114/9b619ff1/attachment.asc>