[FFmpeg-devel] [PATCH 2/2] vble: use add_hfyu_median_prediction()

Derek Buitenhuis derek.buitenhuis at gmail.com
Mon Nov 14 06:41:51 CET 2011


On 13/11/2011 9:24 PM, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer<michaelni at gmx.at>
> ---
>   libavcodec/vble.c |   30 +++++++++++-------------------
>   1 files changed, 11 insertions(+), 19 deletions(-)

Hoorah. I couldn't figure out quite how to make this work before.

> +    int i;

This should be at the top of the function.

> +    for (i = 1; i<  width; i++)
> +            dst[i] = dst[i - 1] + val[i];

This is double indented.

> +        int left = 0;
> +        int left_top = dst[0];

Declarations should be at the top of the function.

Rest looks good.

- Derek


More information about the ffmpeg-devel mailing list