[FFmpeg-devel] [PATCH 2/2] lavfi: reimplement MPlayer's af_pan filter for libavfilter.

[Nicolas George]

Le primidi 21 brumaire, an CCXX, Stefano Sabatini a écrit :
> nit: maybe L00:L01:L02...
> would be more math friendly, unmatched trailing "]" or I'm blind

Superseded by the syntax change.

> Please give hints about what the gain level represents (e.g. a number
> ranging in the 0.0-1.0 interval or whatever).

Added someplace.

> hard on my eyes, maybe easier:
> pan=stereo:c0=0.4:0:0:0.4:0.2:0, c1=0:0.2:0.3:0.3:0.1:0.1
> 
> or even:
> pan=stereo:FL=0.4:0:0:0.4:0.2:0,FR=0:0.2:0.3:0.3:0.1:0.1
> 
> anyway I think the spec for each channel specification should go
> separated from the others.

New syntax in the incoming patch.

> I'd say FFmpeg -> @file{ffmpeg} for making clear that the *tool* is
> referenced, rather than the project.

Done.

> Nit: alphabetical order.

Done.

> > +#include <stdlib.h>
> > +#include "libavcodec/avcodec.h"
> unnecessaries?

stdlib was for strtod, which I replaced by sscanf (and thus replaced stdlib
by stdio).

avcodec.h was for audioconvert.h, I replaced it.

> Nit+++: "Unknown ..."

Fixed.

> A validity check on the parsed value may be helpful, and another check
> on range for ensuring that it won't overflow.

Done.

> Nit+++: "Max ..."

Fixed.

> Nit++: this is called *before* filter_samples, so i'd prefer to define
> it before.

Me too, changed.

> Nit: alphabetical order.

Done.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111112/ce855cea/attachment.asc>