[FFmpeg-devel] [PATCH] vda: set destination image buffer attributes

[Michael Niedermayer]

On Wed, Nov 09, 2011 at 02:34:49PM +0100, Sebastien Zwickert wrote:
> 
> On Nov 9, 2011, at 1:34 PM, Michael Niedermayer wrote:
> 
> > On Wed, Nov 09, 2011 at 09:04:39AM +0100, Sebastien Zwickert wrote:
> >> [...]
> > 
> >> +    cv_pix_fmt_type = kCVPixelFormatType_422YpCbCr8;
> > 
> > should this not be set depending on AVCodecContext.pix_fmt ?
> 
> AFAIK at this stage the AVCodecContext.pix_fmt is the pixel format for vda (PIX_FMT_VDA_VLD). Or I missed something ?

no, this was my mistake
i was just thinking the pix_fmt should be set to what is encoded in
h264, i had missed that AVCodecContext.pix_fmt would be the hwaccel
pix_fmt


> 
> However this pixel format type which defines the type of the vda decoder output CoreVideo buffer  should be set by the client itself.
> I'll provide a patch in this way.

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111109/8040aabf/attachment.asc>