[FFmpeg-devel] [PATCH 4/8] libutvideodec: original_format is big endian

[Reimar Döffinger]

On Mon, Nov 07, 2011 at 01:26:13PM -0500, Derek Buitenhuis wrote:
> On 07/11/2011 1:21 PM, Reimar Döffinger wrote:
> >The (broken) way this is currently, this will actually change the data
> >that DecodeBegin gets, so one of these should be plain out wrong.
> >Has someone ever tried to use libutvideo on big-endian?
> >How about this wrapper?
> 
> This does NOT change what DecodeBegin gets, since this:
> 
> http://git.videolan.org/?p=ffmpeg.git;a=blobdiff;f=libavcodec/libutvideo.cpp;h=f10b6f103edc5641051d9b26262c84c06de6557a;hp=15e6840afac01d6106d004a1ae53401ac0d027d9;hb=e3475198779f806115079c9128172543b37243e6;hpb=13665c87678bb064d4ab7e954a02a9337351460d
> 
> It is not actually used anywhere, other than informational purposes now.

I don't see how that commit is relevant.
You change the value you read into the info struct.
You pass the info struct to DecodeBegin.
That info.original_format is no longer used in-between doesn't change
anything about that...