[FFmpeg-devel] video corruption using h264 hw decoders

[Michael Niedermayer]

On Sun, Nov 06, 2011 at 01:24:59AM +0100, Joakim Plate wrote:
> On Thu, 3 Nov 2011 16:22:23 +0100, Michael Niedermayer wrote:
> 
> > On Thu, Nov 03, 2011 at 12:13:07AM +0100, Joakim Plate wrote:
> >> [25 quoted lines suppressed]
> > 
> > iam not against it if it works but it leaves ambiguity for the left
> > and top crop
> > 
> > 
> > [...]
> 
> So here's the patch. As you say it does leave an ambuigity for left/top
> crop. But that was there before too. Exposing crop using pan_scan could be
> an option, but could potentially break compatibility.
> 
> pan_scan does have a somewhat different meaning, even if it does fit the
> bill rather nicely.
> 
> There is one issue with this patch. It doesn't detect changes in crop
> values during playback. I'm not sure that matters too much thou seing as
> cropping is not fully handled anyway. Also flushing all reference frames on
> crop changes seem wrong as well.
> 
> fate passes, and i've not seen any odd behaviour in the samples i've tried.
> 
> /Joakim
> 

> Ps. Any reason those CHROMA444 stuff is there? Why not use croma_x_shift
> the same way as croma_y_shift is used?

so it can be #defined to 0 allowing the compiler to optimize the code
out.



>  h264.c |   10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> cd0853c21dd805653d144bbb692c4aa6d3587b1a  0001-Set-avctx-coded_width-height-to-uncropped-h264-sizes.patch
> From 641cc9c7d1befd8f895b1927c3bdbeb432a9f377 Mon Sep 17 00:00:00 2001
> From: Joakim Plate <elupus at ecce.se>
> Date: Sun, 6 Nov 2011 00:59:37 +0100
> Subject: [PATCH] Set avctx->coded_width/height to uncropped h264 sizes

applied, will push after testing


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111106/3534be04/attachment.asc>