[FFmpeg-devel] [PATCH] Mark AVFilterPad[] compound literals as const.

[Clément Bœsch]

On Sat, Nov 05, 2011 at 03:11:40PM +0100, Nicolas George wrote:
> Le quintidi 15 brumaire, an CCXX, Clément Bœsch a écrit :
> > > +    .inputs    = (const AVFilterPad[]) {{ .name            = "default",
> > >                                      .type            = AVMEDIA_TYPE_AUDIO,
> > >                                      .filter_samples  = filter_samples,
> > >                                      .min_perms       = AV_PERM_READ, },
> > >                                    { .name = NULL}},
> > 
> > Do you mind keeping the vertical alignment? :)
> 
> Usually, this is done in a separate patch.
> 
> And the lines will go beyond 80 columns. Better write it as:
> 
>     .inputs    = (const AVFilterPad[]) {
>         { .name            = "default",
> 	  .type            = AVMEDIA_TYPE_AUDIO,
> 	  .filter_samples  = filter_samples,
> 	  .min_perms       = AV_PERM_READ, },
> 	{ .name = NULL}
>     },
> 

I was thinking of just aligning the '=' after the .name attribute (line is
already changed anyway) and avoid a huge reindent patch.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111105/63f1e861/attachment.asc>