[FFmpeg-devel] [PATCH] Mark AVFilterPad[] compound literals as const.

Nicolas George nicolas.george at normalesup.org
Sat Nov 5 15:11:40 CET 2011


Le quintidi 15 brumaire, an CCXX, Clément Bœsch a écrit :
> > +    .inputs    = (const AVFilterPad[]) {{ .name            = "default",
> >                                      .type            = AVMEDIA_TYPE_AUDIO,
> >                                      .filter_samples  = filter_samples,
> >                                      .min_perms       = AV_PERM_READ, },
> >                                    { .name = NULL}},
> 
> Do you mind keeping the vertical alignment? :)

Usually, this is done in a separate patch.

And the lines will go beyond 80 columns. Better write it as:

    .inputs    = (const AVFilterPad[]) {
        { .name            = "default",
	  .type            = AVMEDIA_TYPE_AUDIO,
	  .filter_samples  = filter_samples,
	  .min_perms       = AV_PERM_READ, },
	{ .name = NULL}
    },

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111105/05dfa8d7/attachment.asc>


More information about the ffmpeg-devel mailing list