[FFmpeg-devel] [PATCH] lavfi: add avolume filter

[Stefano Sabatini]

On date Thursday 2011-11-03 01:24:14 +0100, Stefano Sabatini encoded:
> On date Wednesday 2011-11-02 21:47:10 +0100, Nicolas George encoded:
> > Le duodi 12 brumaire, an CCXX, Stefano Sabatini a écrit :
> > > * maybe I should change the syntax for the relative value, indeed
> > >   avolume=2.0 is confusingly different from avolume=2, I could for
> > >   example require to add an x (as times) to it.
> > >   So we would have:
> > >   avolume=2x
> > >   for increasing volume by two.
> > 
> > My humble opinion about that is that, for the users, the order of usefulness
> > is: "avolume=1.5" > "avolume=+3.5dB" > "avolume=384", and therefore, the
> > syntax should make the first one the most accessible.
> > 
> > What about: if there is a sign at the start, then it is in decibels, else it
> > is a float factor, and use the eval interface to get the value? This, the
> > above becomes: "avolume=1.5" > "avolume=+3.5" > "avolume=384/256".
> 
> Nice idea, I preferred to make the user specify "dB" and considered
> the -+ optional in the decibel expression.
> 
> Also fixed various overflow problems, and renamed the filter to
> "volume".
> -- 
> FFmpeg = Frenzy and Friendly Moronic Portentous Erratic God

> From 9c8c40fda4e1510cc5cd7763799585dca616c25a Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefasab at gmail.com>
> Date: Tue, 1 Nov 2011 21:42:14 +0100
> Subject: [PATCH] lavfi: add volume filter
> 
> ---
>  doc/filters.texi         |   50 ++++++++++++
>  libavfilter/Makefile     |    1 +
>  libavfilter/af_volume.c  |  191 ++++++++++++++++++++++++++++++++++++++++++++++
>  libavfilter/allfilters.c |    1 +
>  4 files changed, 243 insertions(+), 0 deletions(-)
>  create mode 100644 libavfilter/af_volume.c

Integrated.
-- 
FFmpeg = Fascinating and Fundamental Magic Pure Easy Geisha