[FFmpeg-devel] [PATCH] ffmpeg: add -map_channel option.

[Clément Bœsch]

On Mon, Oct 31, 2011 at 06:07:37PM +0100, Clément Bœsch wrote:
> On Fri, Oct 28, 2011 at 02:29:52AM +0200, Clément Bœsch wrote:
> [...]
> > From 7df0c3b531f290f4f560c91a57c7cfa01a322164 Mon Sep 17 00:00:00 2001
> > From: =?UTF-8?q?Cl=C3=A9ment=20B=C5=93sch?= <clement.boesch at smartjog.com>
> > Date: Mon, 17 Oct 2011 10:33:47 +0200
> > Subject: [PATCH] ffmpeg: add -map_channel option.
> 
> New patch reworked again. libswresample part should now be OK according to
> Michael (the map audio channel takes over the input channel layout instead
> of a previous hack for instance).
> 
> I also added some regression tests (not sure if it's the appropriate
> place, so if anyone could have a look...).
> 
> Now a bikeshed question: is anyone OK with the "-map_channel" name?
> Originally the option was named "-map_audio_channel", but the syntax is
> different and I'd like eventually to avoid a pain in the ass for Baptiste
> to deal with the conflict (since he still maintains the
> "-map_audio_channel" option in FFmbc); two options with the same name but
> different syntax can be confusing for the users of both projects.  Also,
> "-map_audio_channel" is quite a long option name, and the cmd line gets
> really big when using multiple times the option (which is common). So if
> you think of an alternative, please keep it short.
> 
> If no one complains during the following 3 days, I'll push this patch.
[...]

Rebased (minor bump updated from 1 to 2) and pushed slightly differently
(I added a check to set used_ch_count earlier in swr_init() because the
input channels could be set after swr_alloc2()).

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111104/4ff39695/attachment.asc>