[FFmpeg-devel] [PATCH] lavfi: add avolume filter

[Reimar Döffinger]

On Thu, Nov 03, 2011 at 10:14:30PM +0100, Reimar Döffinger wrote:
> On Thu, Nov 03, 2011 at 01:24:14AM +0100, Stefano Sabatini wrote:
> > +    .inputs  = (AVFilterPad[])  {{ .name           = "default",
> > +                                   .type           = AVMEDIA_TYPE_AUDIO,
> > +                                   .filter_samples = filter_samples,
> > +                                   .min_perms      = AV_PERM_READ, AV_PERM_WRITE},
> > +                                 { .name = NULL}},
> 
> Sorry for coming in with something unrelated and that probably was
> discussed already a long time ago, but why are these not
> "const AVFilterPad[]"?

Let me clarify that it looks to me that this causes _a lot_ of data
to be in .data that should really be in .rodata (for performance,
security and other reasons).