[FFmpeg-devel] video corruption using h264 hw decoders

[Michael Niedermayer]

On Thu, Nov 03, 2011 at 12:13:07AM +0100, Joakim Plate wrote:
> On Tue, 1 Nov 2011 03:06:06 +0100, Michael Niedermayer wrote:
> 
> > On Sun, Oct 30, 2011 at 11:32:11PM +0100, Joakim Plate wrote:
> >> [5 quoted lines suppressed]
> > 
> > If this works and is tested with videos that change resolution then
> > iam fine with it.
> > 
> > [...]
> 
> Okey, done some testing with this. Problem is we don't know we are hw
> decoding when avcodec_set_dimensions is called the first time, thus we'd
> start by initing wrong size. This is around line 2700 ish in h264.c. This
> is what we tried (against older ffmpeg so not really interesting:
> http://pastebin.com/G6hZ0PpA)
> 
> I noticed a bug there looking at it it. It's using avctx->width/height to
> check for changes compared to sps info. But width/height can have been
> modified by low_res (not that that is supported). But i think the check
> should be against coded_width/height.
> 
> This brings me to an alternate idea. What about never cropping
> coded_width/coded_height, only apply cropping to width/height parameters.
> 
> What do you think?

iam not against it if it works but it leaves ambiguity for the left
and top crop


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

DNS cache poisoning attacks, popular search engine, Google internet authority
dont be evil, please
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111103/4e3568ea/attachment.asc>