[FFmpeg-devel] [PATCH] lavfi: add avolume filter

[Michael Niedermayer]

On Wed, Nov 02, 2011 at 09:27:58PM +0100, Stefano Sabatini wrote:
> On date Wednesday 2011-11-02 09:24:39 +0100, Nicolas George encoded:
> > Le duodi 12 brumaire, an CCXX, Stefano Sabatini a écrit :
> > > + at var{output_volume} = 10^(@var{vol}/10) * @var{input_volume}
> > 
> > Unless I am mistaken, the formula should be 10^(vol/20): the decibels are
> > measured on the power, which is proportional to the square of the linear
> > volume. If the volume is multiplied by 10, its square is multiplied by 100,
> > thus +20dB.
> > 
> > At the very least, that is how mplayer does it.
> 
> Updated with this change.
> 
> Bikesheds:
> * "volume" might be preferred over "avolume", since there is no
>   conflict possibility.
> 
> * maybe I should change the syntax for the relative value, indeed
>   avolume=2.0 is confusingly different from avolume=2, I could for
>   example require to add an x (as times) to it.
>   So we would have:
>   avolume=2x
>   for increasing volume by two.
> 
> Opinions?

iam happy with anything you and nicolas agree to

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111102/b41c9d7c/attachment.asc>