[FFmpeg-devel] [PATCH] Replace all strcasecmp/strncasecmp usages.

[Michael Niedermayer]

On Wed, Nov 02, 2011 at 08:26:19PM +0100, Reimar Döffinger wrote:
> All current usages of it are incompatible with localization.
> For example strcasecmp("i", "I") != 0 is possible, but would
> break many of the places where it is used.
> Instead use our own implementations that always treat the data
> as ASCII.
> 
> Signed-off-by: Reimar Döffinger <Reimar.Doeffinger at gmx.de>
> ---
>  libavdevice/v4l2.c                   |    4 ++--
>  libavfilter/libmpcodecs/vf_palette.c |   20 ++++++++++----------
>  libavformat/avidec.c                 |    4 ++--
>  libavformat/http.c                   |   17 ++++++++---------
>  libavformat/img2.c                   |    7 +++----
>  libavformat/matroskaenc.c            |    4 ++--
>  libavformat/metadata.c               |    6 +++---
>  libavformat/mp3enc.c                 |    3 +--
>  libavformat/nutdec.c                 |    5 ++---
>  libavformat/rtpdec.c                 |    4 ++--
>  libavformat/rtpdec_mpeg4.c           |    3 +--
>  libavformat/rtsp.c                   |   11 +++++------
>  libavformat/utils.c                  |    7 +++----
>  libavutil/avstring.c                 |   27 +++++++++++++++++++++++++++
>  libavutil/avstring.h                 |   12 ++++++++++++
>  libavutil/avutil.h                   |    2 +-
>  libavutil/internal.h                 |    4 ++++
>  libavutil/parseutils.c               |    7 +++----
>  18 files changed, 91 insertions(+), 56 deletions(-)

LGTM, thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111102/0aa4335d/attachment.asc>