[FFmpeg-devel] [PATCH 3/3] Fix various uninitialized variable warnings

[Clément Bœsch]

On Mon, May 30, 2011 at 12:20:19AM +0200, Michael Niedermayer wrote:
> On Sun, May 29, 2011 at 09:07:36PM +0200, Clément Bœsch wrote:
> > ---
> >  ffplay.c                  |    2 +-
> >  libavformat/iff.c         |    2 +-
> >  libavformat/matroskadec.c |    3 ++-
> >  3 files changed, 4 insertions(+), 3 deletions(-)
> 
> are all these warnings false positives?
> if so there should be comments explaining that the =0 is just to
> silence a warning and not strictly needed.
> This makes code easier to understand.

For the ffplay.c it's hard to say, I'm not familiar with the code enough.

In iff, I'd say no if the codec_type is not audio or video (I guess it can
happen).

And for the matroskadec, it is indeed a false positive, but I wonder if
it's worth commenting that change.

> 
> thx btw for the warning fixing work
> 

There are a lot of deprecated warnings too, I may take some time fixing
them. But what bugs me the most are the const issues all over the place;
while it's possible to fix some of them, it looks like it is generally due
to some inconsistency in the API (or an abuse of const), so I won't change
them.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110530/a2af8e3d/attachment.asc>