[FFmpeg-devel] [FFmpeg-cvslog] rawdec: factor video demuxer definitions into a macro.

[Michael Niedermayer]

On Sun, May 29, 2011 at 03:14:02PM -0400, Mike Scheutzow wrote:
> Anton Khirnov wrote:
>> ffmpeg | branch: master | Anton Khirnov <anton at khirnov.net> | Wed May 25 08:14:13 2011 +0200| [fa4924a35818b2564050119ed7c14cbdd2b56065] | committer: Anton Khirnov
>>
>> rawdec: factor video demuxer definitions into a macro.
>>
>>   
>>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=fa4924a35818b2564050119ed7c14cbdd2b56065
>>>     
>> ---
>>
>>  libavformat/cavsvideodec.c |   11 +----------
>>  libavformat/diracdec.c     |   11 +----------
>>  libavformat/dnxhddec.c     |   11 +----------
>>  libavformat/h261dec.c      |   12 +-----------
>>  libavformat/h263dec.c      |   12 +-----------
>>  libavformat/h264dec.c      |   12 +-----------
>>  libavformat/m4vdec.c       |   12 +-----------
>>  libavformat/mpegvideodec.c |   11 +----------
>>  libavformat/rawdec.c       |   23 ++---------------------
>>  libavformat/rawdec.h       |   12 ++++++++++++
>>  10 files changed, 22 insertions(+), 105 deletions(-)
>> ...
>>
>>   
>
> This patch feels like a step backwards to me.
>
> It is simply documentation removal, for no benefit.
>
> How is it better that developers have to decode another level of  
> indirection when reading source code?

i agree
anton, could you comment?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110530/db7330ef/attachment.asc>