[FFmpeg-devel] postprocess.c: replace check for p==NULL with *p==0

Michael Niedermayer michaelni at gmx.at
Sun May 29 00:17:24 CEST 2011

On Sat, May 28, 2011 at 07:44:05PM +0200, Piotr Kaczuba wrote:
> It seems that the check for p==NULL in libpostproc/postprocess.c in the  
> filter name replacement code is quite pointless as p can never be NULL.  
> It should be probably *p==0 as the code wants to check for the end of  
> the string. See attached patch.
> -- 
> Cheers,
> Piotr

>  postprocess.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 5cf6904b61eac7ecbcae6946c951b4fd5bee118c  postprocess2.diff

i suspect this change can break in some corner cases like recursive


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110529/7b77467d/attachment.asc>

More information about the ffmpeg-devel mailing list