[FFmpeg-devel] [PATCH] cmdutils: remove OPT_FUNC2

Stefano Sabatini stefano.sabatini-lala at poste.it
Sat May 28 18:42:06 CEST 2011


On date Wednesday 2011-05-25 11:39:41 +0200, Stefano Sabatini encoded:
> On date Wednesday 2011-05-25 03:14:15 +0200, Michael Niedermayer encoded:
> > On Tue, May 24, 2011 at 08:19:31PM +0200, Stefano Sabatini wrote:
> > > Make ff* tools only accept opt_* functions taking two arguments.
> > > 
> > > The distinction between functions with one and two arguments is quite
> > > pointless. Simplify parse_options() code.
> > > ---
> > >  cmdutils.c             |   10 +--
> > >  cmdutils.h             |   12 +--
> > >  cmdutils_common_opts.h |    2 +-
> > >  ffmpeg.c               |  215 ++++++++++++++++++++++++++----------------------
> > >  ffplay.c               |   35 ++++----
> > >  ffprobe.c              |    7 +-
> > >  6 files changed, 148 insertions(+), 133 deletions(-)
> > 
> > if you/people prefer this then ok with me
> 
> Yes I prefer this, it simplifies the cmdutils code and improves
> reporting.
> 
> I'll apply soon.

Applied (it was also applied to Libav with the necessary changes, no
need to pull).
-- 
FFmpeg = Friendly & Free MultiPurpose Elastic Gadget


More information about the ffmpeg-devel mailing list