[FFmpeg-devel] [WIP] select filter

[Michael Niedermayer]

On Mon, May 23, 2011 at 12:59:33AM +0200, Stefano Sabatini wrote:
> On date Sunday 2011-05-22 01:14:49 +0200, Stefano Sabatini encoded:
> > On date Sunday 2011-05-22 01:14:01 +0200, Stefano Sabatini encoded:
> > > On date Saturday 2011-05-21 14:20:20 +0200, Michael Niedermayer encoded:
> > > > On Fri, May 20, 2011 at 10:17:32AM +0200, Stefano Sabatini wrote:
> > > > > Please comment on design and syntax, depends on patches:
> > > > >     vsrc_buffer: return an error code if no frames are available
> > > > >     ffmpeg: handle the case when get_filtered_frame() fails
> > > > > 
> > > > > Missing documentation.
> > > > > -- 
> > > > > FFmpeg = Funny Formidable Moronic Puristic Ecumenical Generator
> > > > 
> > > > >  Makefile     |    1 
> > > > >  allfilters.c |    1 
> > > > >  vf_select.c  |  264 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > > > >  3 files changed, 266 insertions(+)
> > > > > df88016805e3ef4a44d3c1bb95bef2a7263e7932  0003-lavfi-add-select-filter.patch
> > > > > From 08880c08d188aa8c0528f69178716d9ad430bd61 Mon Sep 17 00:00:00 2001
> > > > > From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> > > > > Date: Sat, 7 May 2011 02:06:25 +0200
> > > > > Subject: [PATCH] lavfi: add select filter
> > > > 
> > > > IMO this filter should be commited
> > > > 
> > > > also a "skip similar frames" filter would be usefull, and should be
> > > > able to share quite a bit of code with this
> > > 
> > > Extended with an idea which I had today.
> > > 
> > > If the source declares it has cached frames, select enables a "cache
> > > mode", frames are requested and cached in the select filter in case
> > > they meet the select condition, and immediately returned in
> > > request_frame().
> > > 
> > > This should/can be improved, indeed now it caches only one frames, in
> > > case poll_frame() declares N frames, request() in cache-mode should be
> > > called N times, each selected frame should be cached, poll will
> > > finally return the number of selected cached frames.
> > > 
> > > Seems to work fine in my mind simulator, I'll try to extend the idea
> > > to N frames (which should be rather easy).
> > > 
> > > BTW buffer should also be extended to support multiple frames caching.
> > 
> > ... and patch.
> 
> Updated with support to multiple frames caching.
> 
> Missing documentation yet.
> -- 
> FFmpeg = Foolish Fabulous Meaningless Philosofic Esoteric Game

>  Makefile     |    1 
>  allfilters.c |    1 
>  vf_select.c  |  328 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 330 insertions(+)
> 213fdba0e7c32c7b685ef71240abf6f3292fcee5  0003-lavfi-add-select-filter.patch
> From e6c5fc45ed8ecb9946de952de37029a18e776242 Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> Date: Sat, 7 May 2011 02:06:25 +0200
> Subject: [PATCH] lavfi: add select filter
> 
> Address trac issue #92.

looks great

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110523/9d3c246a/attachment.asc>