[FFmpeg-devel] [PATCH] provide an input parameter to specify 3d stereo format for mkv/webm 3d videos
Michael Niedermayer
michaelni at gmx.at
Fri May 20 03:13:59 CEST 2011
On Sat, May 07, 2011 at 09:44:26PM +0400, Kirill Gavrilov wrote:
> Hi,
>
> I prepare new patch based on Alok. It read and write stereo mode flag using
> metadata tags.
> Also it reads combined planes virtual streams and mark them like:
> stereo_mode -> left_3
> stereo_mode -> right_3
>
> 2011/4/26 Reimar Döffinger <Reimar.Doeffinger at gmx.de>
>
> > I think it would be more user-friendly to allow an actual string instead
> > of just numbers, also specifying a value that is not supported should at
> > least print a warning or even fail.
> >
> In patch integers were replaced with strings. But the problem is
> that names for stereoscopic formats are not standardized
> and this is unclear how user should select them (but sure - magic integers
> not better)...
>
> if ((tag = av_metadata_get(st->metadata, "stereo_mode", NULL, 0)) ||
> > (tag = av_metadata_get( s->metadata, "stereo_mode", NULL, 0)))
> > ...
> > Will prefer stream metadata but can also use global metadata.
> > Of course the proper solution is to implement a way to specify
> > per-stream metadata on the command-line.
> >
> This is ugly but while no way to setup metadata per stream from console -
> may be useful.
> I'll try to implement per stream metadata setup for ffmpeg but its options
> logic is much complicated
> and I fear to write something stupid...
> -----------------------------------------------
> Kirill Gavrilov,
> Software designer.
> matroska.h | 29 ++++++++++++-
> matroskadec.c | 121 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
> matroskaenc.c | 55 ++++++++++++++++++++++++++
> 3 files changed, 200 insertions(+), 5 deletions(-)
> 3e7ab90facea5abcf85d588d07e780afa3d0288c mkv_stereo.patch
i will apply this in the next few days unless i hear objections or
request to wait longer from aurel (in CC)
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110520/b63e17bc/attachment.asc>
More information about the ffmpeg-devel
mailing list