[FFmpeg-devel] [PATCH 1/2] Parse MXF partitions

[Baptiste Coudurier]

Hi Tomas,

On 05/17/2011 07:44 AM, Tomas Härdin wrote:
> Forked from the thread "[PATCH] MXF index table based seeking" to avoid
> cluttering the original thread up.
> 
> Baptiste Coudurier skrev 2011-05-17 05:31:
>>>   typedef struct {
>>> +    MXFPartition **partitions;
>>> +    unsigned partitions_count;
>>
>> Any reason you don't use MXFPartition *partitions ?
>> It avoids malloc for each partition.
> 
> No reason at all. Reworked.
> 
>>> [...]
>>>
>>> +
>>> +    /* consider both footers to be closed (there is only Footer and
> CompleteFooter) */
>>> +    partition->closed = partition->type == Footer || !(uid[14]&  1);
>>
>> Do we really need to workaround here ?
> 
> Not really a workaround, just a statement of fact. There's no such thing
> as OpenFooter, hence we might as well set closed correctly.

Patch ok, feel free to apply it when you want.

About ClosedFooter, do you mean the 'closed' bit is not set and it's
safer to override it ?

-- 
Baptiste COUDURIER
Key fingerprint          8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                           http://www.ffmpeg.org