[FFmpeg-devel] [PATCH] preset dir for win32

[Gianluigi Tiesi]

On Tue, May 17, 2011 at 12:28:48AM +0200, Michael Niedermayer wrote:
> On Mon, May 16, 2011 at 10:35:26PM +0200, Reimar D?ffinger wrote:
> > On Mon, May 16, 2011 at 06:00:11PM +0200, Michael Niedermayer wrote:
> > > On Sat, May 14, 2011 at 08:26:39AM +0200, Gianluigi Tiesi wrote:
> > > > Hi,
> > > > 
> > > > this patch make win32 ffmpeg search in a subdir of the executable called
> > > > presets, datadir does not fit enough well on win32
> > > 
> > > please explain/elaborate on what this fixes.
> > > To me it would look like FFMPEG_DATADIR could be set to whatever
> > > directory is wanted, obviously iam missing some problem
> > 
> > I think the idea is to look for presets relative to the location of
> > the FFmpeg binary.
> > So the presets will be available even after moving all installation
> > files around (as e.g. when providing a binary with installer and
> > user-selectable installation destination) and also when not
> > starting the binary from the directory where it is installed.
> 
> ok, makes sense but i think this should be done in addition and
> not as alternative.
> I dont want to break existing presets
> 

a compile time DATADIR is not suitable on win32, searching in home may be an idea
but on win32 explorer wont make directories starting with dots.
The environment variable FFMPEG_DATADIR is reasonable but not a common pratique.

An idea can be to have FFMPEG_DATADIR as a char ptr on win32
(inited somewhere to executabledir\ffpresets) and get_preset_file()
unchanged

Regards

-- 
Gianluigi Tiesi <sherpya at netfarm.it>
EDP Project Leader
Netfarm S.r.l. - http://www.netfarm.it/
Free Software: http://oss.netfarm.it/